Robert Bastian

Results 389 comments of Robert Bastian
trafficstars

Tracking remaining changes in #5015

https://docs.google.com/document/d/16Js0nBEntjkKZsFWGBjjRrqjD3LRkbFAcKjWhJT4_6M/edit?disco=AAAA1bvCGxU

A couple thoughts: * I would consider using platform provided `resb` files a power user feature, similar to how non-compiled data is a power user feature these days. Hence this...

Shouldn't this be part of Cargo, not `rustfmt`?

Consider using the [`cargo_toml`](https://docs.rs/cargo_toml) crate to parse `Cargo.toml` instead of doing it yourself

> get_ratio() should consume the object You'll need both, checking `.is_reciprocal()` should not consume. > and what is the point of have IcuRatio if we are going to get_ratio() for...

> Once the user issues the internal structure, this means that it will be used as it is in another place, such as in the converter. If the user wants...

Outside experimental it gets a lot messier, there are many interactions between e.g. calendar/datetime/timezone, decimal/compactdecimal, a lot of things/properties. This will require extensive restructuring of the datagen crate, which I...

> I'm weakly against removing the features. It seems like people have stronger reasons to remove it. We don't currently have these. We have a single experimental feature.

You need to put the constructor `diplomat::attr` on the constructor.