Robert Bastian

Results 390 comments of Robert Bastian
trafficstars

This is a data struct bump, so I think it's independent of 2.0?

I don't think this is worth the cost of having a second data struct, which comes with a second code path for construction. This increases code size, and complexity in...

- @sffc - Ideally I think that discriminant `0` should be the default/auto value. - @robertbastian - I don't see the issue, Rust users are not casting the enum to...

Compiled data requires that the fallback compiled data in locid transform is at the same version, otherwise deduplication breaks

"still compiles and mostly works" is horrible. We introduced the ~ deps because clients were having issues with mixed versions. If we allow non-~ locid_transform, there will be very silent...

> maintain a soft guarantee that we'll try and mitigate internal breakagaes I'm unclear what this refers to

So what happens if you need a FDF but used this constructor? I like the `try_new_without_number_formatting` concept, but then it should do naive fixed decimal formatting instead of erroring.

> handling _ separately makes engines do double work, since they have to first traverse the string to check for _, then traverse the string to parse the locale. I...