Robert Bastian

Results 390 comments of Robert Bastian
trafficstars

Let's default `--tzdb-root` to `/usr/share/zoneinfo` and print a warning when it's used (i.e. on `SourceData::tzdb`. This way datagen stays usable without compiling your own time zones. This works for Mac...

Merged for ya

> This can help with testing of ICU4X across version numbers Who does this help? We don't do this, who does this? 1.68 and earlier has a soundness bug in...

I'd rather publish patch releases to fix 1.0 and 1.1 than to impose restrictions on 1.5. However, there's nothing in 1.69 that we need; 1.70 contains `OnceCell`, but we'll be...

> which uses the slower Display-based code path instead of the faster Writeable::write_to_string code path. I'm gonna need numbers for this claim.

LGTM with the addition: 4. Properly document this prelude-trait-method shadowing and why we do it (maybe linking to the benchmark)

Well there's a perf regressions even for a single key...

Discussion: we want to update to wasmer 3, but there shouldn't be a performance hit.