Daniel J Walsh
Daniel J Walsh
LGTM @giuseppe PTAL
What would the protections on that file be by default 600 would be my suggestion, and then people who wanted to share it with non root users could open it...
Seems like there is one comment by @mtrmac that was not addressed?
https://github.com/containers/image/pull/2391/files#r1589601556
Should ``` Pushes reusing chunked layers don’t create the required annotations, making the layers impossible to pull chunked: https://github.com/containers/image/pull/2183#pullrequestreview-1725228215 / https://github.com/containers/image/pull/2185 ``` Be closed?
I am fine with this change, BUT this is more then just the code. Documentation and Google Memory will make this difficult.
Any way to pass down a debug flag? Or just rebuild with a DEBUG Tag?
@mtrmac Could you open a trello card with an intern flag, so we could have an intern work on this next summer.
@mtrmac @vrothberg What is the state of this PR? Should we rebase and move forward with it or should we close it?