Rafael Schouten
Rafael Schouten
@Alexander-Barth this should solve it: ```julia function Base.sum(v::AbstractDiskArray) sum(eachchunk(DiskArrays.eachchunk(v))) do chunk sum(v[chunk...]) end end ``` If you want to make a PR we could also define a similar method for...
Ah maybe similar missed out on keywords back then, most other constructor methods e.g. rand/fill got them. Feel free to add them.
Come on guys this is too vague to comment on without a computer in front of me. Please show the comparison between the parent array with `view` and DD with...
Perfect. Yep looks like a bug in `maybeview`. Seems it should unwrap zero dimensional arrays.
Thanks. `@profview` may help. I would make a function that runs it like so ```juia f(AB, ab, n) = for _ in 1:n broadcast_dims(-, AB, ab) ``` And then try...
Ok so the problem is there are a lot of edge cases where your formulation will make the order of arguments change the results - as stack layers don't have...
Good point. We can shift to module dispatch in GI.convert so `geointerface_geomtype` isn't hit. That's the plan anyway with 1.10 being LTS
Can we break this up into smaller PRs so it gets merged sooner? Specifically can we add a PR for `geointerface_geomtypes` just so `convert(GeometryBasices, geom)` works?
1. We already have this, see `mergedims`. 2. `DimArray(stack)` makes a DimArray of NamedTuple over the stacks layers. This is preferable in Julia because it lets the types remain mixed,...
True. `unmergedims` could also reconstruct missing rows like the Tables.jl implementation does