GeometryBasics.jl icon indicating copy to clipboard operation
GeometryBasics.jl copied to clipboard

Move GeoInterace methods to an extension in GeoInterface to remove dependency loops

Open rafaqz opened this issue 1 year ago • 3 comments

As MakieCore depends on GeometryBasics there is no way for GeoInterface to add makie recipes without a dependency loop.

We want the GeoInterface geometries to plot easily, and for our macro to add Makie recipes to be useable from GeoInterface.

The problem is going to be managing the transition without breaking lots of code and / or precompile.

See https://github.com/JuliaGeo/GeoInterface.jl/pull/143

rafaqz avatar Oct 12 '24 11:10 rafaqz

Can you call geointerface_geomtype methods from an extension? Those at least need GI traits for dispatch...

asinghvi17 avatar Oct 12 '24 13:10 asinghvi17

Good point. We can shift to module dispatch in GI.convert so geointerface_geomtype isn't hit.

That's the plan anyway with 1.10 being LTS

rafaqz avatar Oct 12 '24 14:10 rafaqz

Ah, yeah the current method could be kept as a fallback.

asinghvi17 avatar Oct 12 '24 14:10 asinghvi17