Rafael Schouten

Results 1036 comments of Rafael Schouten
trafficstars

Thanks for the fix. I'm wondering if this will break anything.

This must be something to do with how Makie handles quantities... we don't do anything differently between regular numeric lookups and unitful Do plots update if you manually uses observerable...

Thank you that's an amazing MWE. Yes something must have changed in Makie 0.11 that we haven't followed. If you have time for a PR you are probably better placed...

I don't really know what expand_dimension API rules are, is it documented in Makie? What do Makies internal objects return?

Thanks that all makes sense to me. I guess all you can do now is go through the test plots and check they are working after the change. Otherwise I'm...

I didn't know that dispatch was even a thing in Makie, doesn't it need to be `series!` ? We are modifying an existing object...

I'm saying `series` without `!` may work, but it shouldn't ;) Also wondering if this is a Makie bug. @asinghvi17 should Makie conversions always happen to the contents of an...

This sounds good to me. Missing methods for some algorithms/execution policy combinations is fine as long as there is a good error message.

I like how `Base.sort` has `sort!` for in-place methods but also has a `scratch` keyword for the scratch space that some sorts like radix sort needs. Graphs could do something...

As the maintainer of a package that uses Graphs.jl but never Distributed or SharedArrays, I support this change. We should also move Inflate.jl to an extension, it pulls in binary...