Peter Sobolewski
Peter Sobolewski
I think a lot of these things do show why working with vectors for things like scale bars and text is so much easier than raster graphics, which is why...
This looks cool! Thanks for contributing! Our examples need a title, a tag, and a (brief) description--you can see the documentation here: https://napari.org/dev/developers/contributing.html#adding-examples-to-the-gallery This is causing the docs build to...
So we have a small problem. The test fails are spurious and I've restarted them, but the example doesn't run: https://output.circle-artifacts.com/output/job/f13b5a24-1f6c-4682-a82c-ce5bf68c66f1/artifacts/0/docs/docs/_build/gallery/cursor_sync_custom_overlay.html#sphx-glr-gallery-cursor-sync-custom-overlay-py But the example is passing test: https://github.com/napari/napari/actions/runs/7065938491/job/19238534492?pr=6510#step:11:167 So I...
So I think examples tests dont use Qt, so maybe that's why this example passes with `main`? https://github.com/napari/napari/blob/bb25bda71c1cbb2af4174cbb8963c645254173a3/.github/workflows/test_pull_requests.yml#L167-L176 Edit: I merged https://github.com/napari/docs/pull/256 So building docs should fail if an example...
0.4.19 is out, so to get this in—which I definitely want—I think from: https://github.com/napari/napari/pull/6510#issuecomment-1836942282 we need to go with: > fix this PR for main and milestone for 0.5.0 Can...
OK, so the example is passing tests because the way examples are tested with `runpy.run_path` it won't execute code under `if __name__ == "__main__":` so it just passes. We can...
Ok, looks like everything is good now: https://output.circle-artifacts.com/output/job/ec34d49e-f402-44b2-b11b-2050a7c3a49b/artifacts/0/docs/docs/_build/html/gallery/cursor_sync_custom_overlay.html#sphx-glr-gallery-cursor-sync-custom-overlay-py @jni ready for review!
Here's how it looks now, with the formatting improvement: https://output.circle-artifacts.com/output/job/2f3c51ae-9252-4322-a4d8-1baeb06da033/artifacts/0/docs/docs/_build/html/gallery/cursor_sync_custom_overlay.html#sphx-glr-gallery-cursor-sync-custom-overlay-py @jni @brisvag If you have wording suggestions, please use the suggest feature!
I'm sorry @brisvag @jni I don't quite follow the conversation. I was just trying to fix this to get it over the line. Y'all are going to have to clue...
OK, I'll try to take another look. Just to be clear I didn't write this example, it's a user contribution via image.sc forums (see the OP) that withered due to...