Peter Sobolewski
Peter Sobolewski
Looks like for font_size vispy multiplies by dpi (96 for non mac, 72 mac) and divides by 72: https://github.com/vispy/vispy/blob/af2439895a13f187d840a476bd73ed480f2978f2/vispy/visuals/text/text.py#L588 So let's try the same thing for the y_offset Edit: vispy...
OK, I'll take a look. @brisvag before I change anything, can you see if the DPI correction actually solves the problem? 🙇♂️
Thanks! The difference in font size -- which must be preexisting -- is probably due to the same thing, the dpi difference.
So this is wierd: ``` viewer.window._qt_viewer.canvas._scene_canvas.dpi Out[13]: 149.00000223775552 ``` I was expecting 72 -- or a multiple there of. ``` viewer.window._qt_viewer.canvas._scene_canvas.pixel_scale Out[16]: 2.0 ``` Makes sense. @brisvag what do those...
Yea yours makes sense. 149 makes no sense to me.
Ok, i figured it out, it's indeed correct. vispy is computing it from the physical display dimensions (286 mm by 179 mm) and display resolution (1680 by 1050) which are...
@brisvag So I have an issue: when launching napari, the overlays are created, but neither `self.node.parent` nor `self.node.text.transforms.dpi` yet exist, because the canvas doesn't yet exist? https://github.com/napari/napari/blob/1573b119ae4595df413b1da6c0743ce243b24ee4/napari/_vispy/canvas.py#L629-L638 I thought I'd...
@brisvag of course! thanks. Sorry to be so dense at times! So what I've done is use your 96 dpi as the reference, since you set it up looking nice....
Note: this does not fix https://github.com/napari/napari/issues/7516 Using the understanding from this PR that should be doable, just requires adjusting the size of the box and positioning of the elements in...
@TimMonko I actually see from your post above that the size of the text for the scale is now smaller for you with this PR -- same for me. Can...