Peter Sobolewski

Results 610 comments of Peter Sobolewski
trafficstars

Blerg 🤮 hitting: https://github.com/napari/napari/issues/5803#issuecomment-1553378607 I guess need a real viewer? Maybe I can mock it. Let me poke around.

Thanks @lucyleeow that helped a lot -- it fixed the injection issues. Just don't get now why the regular click isn't resulting in a `trigger` -- if I comment that...

Thanks @dalthviz ! I did look into the _trigger and such but couldn't sort out a good way to mock it. I've implemented your suggestion of just checking that the...

Thanks @DragaDoncila I used your test with the mocking. Should we turn your post above into an issue to keep track of the make_viewer, action_manager, app-model interactions?

I wonder if this is the pyopengl 3.1.7 issue? @JadisInka You mentioned you have a conda install that has the issue but not pip. Can you check the version of...

Thanks for the issue. This came up at the hackathon. We largely agreed that in an end-user script it should be anything goes, with regards to keybinds. I think the...

This is essentially the same issue as https://github.com/napari/napari/issues/2799 and https://github.com/napari/napari/issues/6440 viewer keybindings cannot be over-written. If you can use a `@layer.bind_key` that should work and over-write existing ones in napari.

Looks like this issue https://bugreports.qt.io/browse/QTBUG-41309 Can you try Alt-Enter to exit? or Control-F? Or F11? Or Control-F11? Do any of those exit? Does the View menu > Toggle Full screen...

Hmm, it looks like we thought this was fixed! https://github.com/napari/napari/pull/5401 In fact the code from the fix is what's adding the +2: https://github.com/napari/napari/blob/c10dc9fe50eb40a648ce4112ec2f7ea0541ed798/napari/_qt/qt_main_window.py#L332-L337 @dalthviz any ideas? Also I wonder if...

Thanks for the clarification that with 0.5.3 the issue is the interaction between Windows maximize and napari Full Screen. That makes it a bit more of a corner case, but...