pseeth

Can you post some audio examples comparing the two somewhere?

Let's merge master into this and then we can merge this.

Some care to be taken here - the regression data will conflict with master.

@abugler, please update the docstring for `time_stretch` when you get a chance to make it super clear that we are _dynamically_ choosing which type of stretching to apply! I also...

Can you also regenerate this notebook with your fixed code so we can compare the audio with stretch vs tempo? https://nbviewer.jupyter.org/github/abugler/sox_tempo_stretch/blob/master/Tempo_Stretch.ipynb

> This doesn't use `nussl.core.effects`! It only uses nussl to embed the audio into the notebook. Oh I see! Can you make it using `nussl` just so we can hear...

Got it, so perhaps we won't merge this one then until we do some further investigation? Maybe we should raise this as an issue to the PySox devs? With audio...

Hmm, we'll have to look into this. @maxrmorrison, do you mind testing this when you get some free time? I had at least one person with Windows try examples using...

Yep, we need a process for this still for sure. Let's discuss here when we get a chance to think about it!

Hi @bryan-pardo, yeah the multitrack player can be improved for sure...it's down to using media elements to play the audio instead of using something more robust like Web Audio API....