pseeth

Inside init with the scan disabled sounds like best of both worlds. I think the actual scan should also be a top-level function - not within the Scaper object, but...

Might be unrelated or a diff PR, but here's another unhelpful warning that someone got: ``` scaper/core.py", line 1865, in generate jam.save(jams_path) File "/home/abugler/.conda/envs/nussl/lib/python3.7/site-packages/jams/core.py", line 1776, in save self.validate(strict=strict) File...

To tag on a bit, a `min_overlap` could also be nice, to make sure that generated scenes aren't trivial for source separation networks to solve, if using Scaper for the...

I can replicate the off by one error in the test cases (it fails the strict test, which just does a straight sum). To sum the intermediate source files in...

Oh, yeah this should be closed, I think. We now have `fix_clipping=True`, and we sum everything up in-memory. Let us know if it's broken in the most recent version of...

Hey guys, I just saw this discussion. Mixing coherent music mixtures is actually quite tricky and a bit hacky. I have this script to do it with musdb if you're...

#53 is now in Scaper, @beasteers, does it address this issue?

@bmcfee, would be helpful to get your thoughts, i think!

Okay cool, thanks @bmcfee. We now cast the dictionary to a sandbox in `generate_from_jams()`. Since `_generate_audio` is marked as an internal function, we can probably close this.

The need cropped up in the source separation stuff, because in _generate_audio we create the actual files and then add them to the sandbox. Since `_generate_audio` gets called by `generate_from_jams`...