pseeth
pseeth
Hmm, I had look at the test case and I do test the code with time stretching and it passes...any chance I could get an MWE from @epicycles to test...
Sounds good. Let me make sure I understand the spec. So once event_duration is decided, we should just sample with the same distribution but with the upper bound changed to...
Yeah, that logic is taken care of already so it shouuuld be a drop-in replacement with the required tests to make sure it works.
Could the sampling of the audio scenes be driven by the distribution of the accepted scenes so far, with a bit of randomness thrown in there to make it more...
Yeah it seems like a heisenbug, hence the rejection sampling haha. I'll see if v1 fixes it once I merge my changes and write some tests! I should probably think...
Should we change the default of disable_sox_warnings from False to True?
Huh, so it actually is already True. My bad. The warnings only occur when their level is critical, apparently. So is it not working? Did John get a lucky run...
Yeah, I don't think it's critical. I did add "If you're experiencing issues related to audio I/O setting this parameter to True may help with debugging" to the docstring in...
This one and #57 can happen simultaneously in one PR, I think. Thoughts @justinsalamon?
Been keeping an eye on keepsake for a few days now, and this would definitely be a great feature that would get me to go all in! Especially if there's...