Peter Rowlands (변기호)

Results 231 comments of Peter Rowlands (변기호)

This is actually the same issue as https://github.com/iterative/dvc-ssh/issues/12. We need to implement the same asyncssh interactive input callbacks in dvc-ssh that we have already done in scmrepo. (In this case...

@Erotemic can you try https://github.com/iterative/dvc-ssh/pull/52 and see if the 2fa prompting works as expected ``` pip install 'dvc-ssh @ git+https://github.com/iterative/dvc-ssh.git@refs/pull/52/head' ```

@Erotemic did you get the 2fa prompt before the fetch fails or did it not prompt you at all?

DVC uses the asyncssh library and not the OpenSSH CLI client, so it doesn't support ControlMaster (which is an OpenSSH client feature). ControlMaster support is discussed in the asyncssh issue...

`dvc-ssh==4.1.0` was just released with support for `KbdInteractiveAuthentication` based 2FA, see https://github.com/iterative/dvc-ssh/pull/52 for a demo. (In the linked demo auth is done via ssh key + 2FA) This is independent...

> How do we use these names at all? do we expect that specific remote name to exist in a config? Yes, they are tied to the remote name defined...

I'm unable to reproduce this in the latest DVC release (3.45.0). Can you try updating and verify whether or not you still see the issue?

Yes as you noted, it's not actually downloading from a remote, it's being copied from your existing cache. Ideally we should be preserving the link type in this case and...

> I'm not sure why it's happening, but feels like this is too fragile to depend on. It's because you are on a platform with case-insensitive filesystems (windows or macos)....

> My concern would be what happens when users do create an overlapping tag since gto will see them as separate artifacts but may fail to create the tag, right?...