Paul Dicker comments

Results 308 comments of


                                            Paul Dicker

trafficstars

add second fraction normalisation

Closing due to inactivity and the concerns raised above. We still have https://github.com/chronotope/chrono/issues/702 to track this issue.

Can't leak crate-private type in stub.rs

I did not try to test this, but believe it can be closed because all these methods were removed in https://github.com/chronotope/chrono/pull/1072.

Additional rkyv support by trying to derive the Archived type as Self where possible

I agree it would be cool if `Copy` types would not even need a serialize/deserialize step when used with `rkyv`. And of course this breaks down when not everything uses...

Add from_timestamp_nanos|micros|millis functions for NaiveDateTime

https://github.com/chronotope/chrono/pull/906 Added these methods last december. @0xdeafbeef Thank you for your work here! This PR can be closed.

Why does `from_timestamp` panic for very small values if `i64` like `i64::MIN`?

An `i64` Unix timestamp can cover a wider range of dates than a `NaiveDateTime` or `DateTime`. Although with a range of +/-260,000 years it already seems pretty generous. To avoid...

plus_months function of the DateLike trait

Added in https://github.com/chronotope/chrono/pull/731.

There is no way to add a "day" to a DateTime

Fixed in https://github.com/chronotope/chrono/pull/784.

Wrong output from `%Z` specifier when using `Local::now().format()`

Closing as duplicate of https://github.com/chronotope/chrono/issues/288.

Export `chrono::naive::time::M{AX,IN}_TIME`

`NaiveTime::MIN` was made public in https://github.com/chronotope/chrono/pull/890. `NaiveTime::MAX` seems a bit questionable to me. For one because it does not account for leap seconds.

add LocalOffset type that stores the timezone name

> We would need to capture timezone name on Windows as well, potentially from [here](https://docs.microsoft.com/en-us/windows/win32/api/timezoneapi/ns-timezoneapi-time_zone_information) hence why this is in draft status for now The `TIME_ZONE_INFORMATION` structure doesn't seem to...