chrono icon indicating copy to clipboard operation
chrono copied to clipboard

Published 20 hours ago • verified publisher icon chronotope

Add from_timestamp_nanos|micros|millis functions for NaiveDateTime

Open 0xdeafbeef opened this issue 4 years ago • 9 comments

  • [x] Have you added yourself and the change to the changelog? (Don't worry about adding the PR number)

0xdeafbeef avatar May 26 '21 14:05 0xdeafbeef

I have been wondering why chrono did not support this before. A lot of other systems use millis and this will ease the transition to rust for people who migrate. :pray:

savnik avatar Feb 09 '22 14:02 savnik

@savnik I've synced fork with recent master

0xdeafbeef avatar Mar 31 '22 15:03 0xdeafbeef

Thanks for working on this!

djc avatar Mar 31 '22 19:03 djc

This is still failing CI and has conflicts. Please fix/rebase.

djc avatar Apr 11 '22 09:04 djc

@djc updated with the latest main, all clippy checks passes

0xdeafbeef avatar Apr 13 '22 11:04 0xdeafbeef

CI is still failing.

djc avatar Apr 13 '22 11:04 djc

@djc I should target rust 1.32?

0xdeafbeef avatar Apr 13 '22 11:04 0xdeafbeef

@djc all fixed, Is there anything else I should do?

0xdeafbeef avatar Apr 22 '22 13:04 0xdeafbeef

I'll try to find time for another round of review soon -- I've been on vacation for a while.

djc avatar May 09 '22 12:05 djc

https://github.com/chronotope/chrono/pull/906 Added these methods last december. @0xdeafbeef Thank you for your work here!

This PR can be closed.

pitdicker avatar May 15 '23 08:05 pitdicker