phlax
phlax
its this that is failing ``` 13 wasm_rust_binary( 14 name = "test_rust.wasm", 15 srcs = ["test_rust.rs"], 16 rustc_flags = ["-Clink-arg=-zstack-size=32768"], 17 precompile = envoy_select_wasm_v8_bool(), 18 ) ``` in `test/extensions/common/wasm/test_data/BUILD` altho...
testing this on test PR ```diff diff --git a/bazel/wasm/wasm.bzl b/bazel/wasm/wasm.bzl index 9350189d8b..1cb9b68f11 100644 --- a/bazel/wasm/wasm.bzl +++ b/bazel/wasm/wasm.bzl @@ -78,7 +78,7 @@ def envoy_wasm_cc_binary(name, additional_linker_inputs = [], linkopts = [], tag...
cool - if my hack above doent work then lets do that
for ref `rustc_flags` implementation is here https://github.com/bazelbuild/rules_rust/blob/61b99cdd18dc918c9023e02431b40496b229e67c/rust/private/rustc.bzl#L1835-L1845
> What is the sequencing requirement for this? i think the two things required to make it work are: - the relevant bot (ie github app) is given workflow trigger...
see here for an example workflow: https://github.com/envoyproxy/go-control-plane/blob/main/.github/workflows/envoy-sync.yaml
> ... would it be possible to change the name of the downstream workflow being invoked, from envoy-sync.yaml for sure - i see the issue - it would at least...
hi - yep - looks good - reviewed there i think we will need to adjust this pr if we want to trigger on branches other than 1.28
i think there are some attempts to resolve the issue of running `no-remote-exec` - that would definitely be preferable also not sure of the wisdom of increasing the vm capacity...
this ```console 2024/11/26 02:00:17 Downloading https://releases.bazel.build/6.5.0/release/bazel-6.5.0-linux-x86_64... ``` and this ... ```console 2024/11/26 02:00:47 Downloading https://releases.bazel.build/7.4.1/release/bazel-7.4.1-linux-x86_64... ``` not sure why its using different bazel versions - but its a bazel fight