envoy icon indicating copy to clipboard operation
envoy copied to clipboard

mobile: Switch to using a large runner for running iOS tests

Open fredyw opened this issue 1 year ago • 5 comments

An attempt to fix https://github.com/envoyproxy/envoy/issues/33488. We suspect that the tests run slow because it has tags = ["no-remote-exec"], which means the tests will be executed locally, which currently runs on a standard runner.

Risk Level: low Testing: CI Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a

fredyw avatar Apr 17 '24 16:04 fredyw

As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/33610 was opened by fredyw.

see: more, trace.

/assign @phlax @abeyad

fredyw avatar Apr 17 '24 16:04 fredyw

friendly ping @phlax

wbpcode avatar Apr 23 '24 02:04 wbpcode

i think there are some attempts to resolve the issue of running no-remote-exec - that would definitely be preferable

also not sure of the wisdom of increasing the vm capacity for ~1 slow test - esp as our macos usage has increased a lot already

disucssing this with @fredyw offline

/wait-any

phlax avatar Apr 23 '24 07:04 phlax

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar May 23 '24 08:05 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar May 30 '24 16:05 github-actions[bot]