envoy
envoy copied to clipboard
envoyproxy
bazel: Add bzlmod support for API/
The enovy_api package must support bzlmod in order for other transitive deps of envoy to support it as well.
Signed-off-by: Keith Smiley [email protected]
As a reminder, PRs marked as draft will not be automatically assigned reviewers, or be handled by maintainer-oncall triage.
Please mark your PR as ready when you want it to be reviewed!
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34355 was opened by keith.
![repokitteh-read-only[bot] avatar](https://avatars.githubusercontent.com/in/16729?v=4 "Published by a pub.dev verified publisher"){kind=small}
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123
:cat:
Caused by: https://github.com/envoyproxy/envoy/pull/34355 was opened by keith.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
We would like to have this.
@fredyw could you re-open and @keith do you plan to continue your work on this?
@keith Thanks! Looks like you need to format your code https://github.com/envoyproxy/envoy/actions/runs/12022333130.
Apart from this, is there anything else missing?
i can't actually tell what failed there, but im attempting to run it locally to see. there might be more to fix once we get past the precheck CI
can't actually tell why that CI job is failing, running that command locally didn't result in any changes
this
2024/11/26 02:00:17 Downloading https://releases.bazel.build/6.5.0/release/bazel-6.5.0-linux-x86_64...
and this ...
2024/11/26 02:00:47 Downloading https://releases.bazel.build/7.4.1/release/bazel-7.4.1-linux-x86_64...
not sure why its using different bazel versions - but its a bazel fight
Looks like that is from this script:
https://github.com/envoyproxy/envoy/blob/d9e1d2269605bdd9e95aedece3da8138c0137be0/tools/proto_format/proto_format.sh#L35-L36
since it does a cd before running, and the version file isn't in there. I can symlink it there, but interestingly that part also isn't new
checking other ci (eg here https://github.com/envoyproxy/envoy/actions/runs/12128588097/job/33815284187#step:16:564) its using the same (already installed perhaps) bazel version
i guess with bzlmod, if you dont specify, bazelisk assumes 7+ for the better support and install different version
ah actually I think it's because I created api/WORKSPACE, so bazelisk no longer looks higher up the tree to find the version file (or .bazelrc), might mean this is broken in new ways
How is https://github.com/envoyproxy/data-plane-api created from this repo? Will the symlink be materialized?
FYI: I uploaded a first version to BCR in https://github.com/bazelbuild/bazel-central-registry/pull/3424.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!