paladox

Results 222 comments of paladox

Closing this as this issue isn't in SMW, it's in the extension.

> Is there any update or workaround for this? > > I guess I can do a patch package... > > My patch for future reference: > > diff --git...

https://github.com/modernweb-dev/web/pull/2932 was merged, so I presume you could open a pr and ping one of the committers?

I've done https://github.com/modernweb-dev/web/pull/2963 which credits you for the fix.

Ah thanks! I'm not sure how to fix that.

Seems https://github.com/modernweb-dev/web/blob/29f73c59f1d3cb7e7fb52363ddf0c37598ecee3e/packages/test-runner-core/src/cli/TestRunnerCli.ts#L282 isn't getting triggered? I created a custom formatter to call it after summeryReporter is called which worked around it. Seems this is caused by https://github.com/modernweb-dev/web/commit/b2c857362d894a9eceb36516af84a800209f187b. Which changed from...

Hmm, even crossing out https://github.com/modernweb-dev/web/blob/29f73c59f1d3cb7e7fb52363ddf0c37598ecee3e/packages/test-runner-core/src/cli/TestRunnerCli.ts#L282 doesn't fix it. But the workaround does. Strange?

Oh I think I know why. It's because we do the logging in https://github.com/modernweb-dev/web/blob/29f73c59f1d3cb7e7fb52363ddf0c37598ecee3e/packages/test-runner/src/reporter/summaryReporter.ts#L103. But we call https://github.com/modernweb-dev/web/blob/29f73c59f1d3cb7e7fb52363ddf0c37598ecee3e/packages/test-runner-core/src/cli/TestRunnerCli.ts#L282 after reportTestFileResults but before onTestRunFinished. So we'd need to add `cachedLogger.logBufferedMessages();` in...