paladox

The main code is broken as well: https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/eb398136b22f3377c8dcb9253edc69f241e07697/src/MediaWiki/Search/SearchEngineFactory.php#L35

I think the solution to this is to change https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/eb398136b22f3377c8dcb9253edc69f241e07697/src/MediaWiki/Search/SearchEngineFactory.php#L35 to `$connection = MediaWiki\MediaWikiServices::getInstance()->getDBLoadBalancer();` I'm not entirely sure if we need to do this here https://github.com/SemanticMediaWiki/SemanticMediaWiki/blame/9e344b00df65cb932eac40dc937df04ebe9340cd/src/Setup.php#L191 or why we have...

The code style needs fixing. ``` 68 | WARNING | [x] Default constraint equalTo() is unneeded and should be | | removed | | (MediaWiki.PHPUnit.MockBoilerplate.ConstraintEqualTo) 69 | WARNING | [x]...

You can see if running composer phpcs-fix fixes it otherwise it'll have to be fixed manually.

``` There were 3 failures: 1) SMW\Tests\Parser\RecursiveTextProcessorTest::testTranscludeAnnotationWithoutUniquidThrowsException Failed asserting that exception of type "RuntimeException" is thrown. 2) SMW\Tests\Parser\RecursiveTextProcessorTest::testTranscludeAnnotation_FALSE Expectation failed for method name is "getOutput" when invoked at least once....

> @paladox but are these failures related to the pull request ? Oh appears not https://github.com/SemanticMediaWiki/SemanticMediaWiki/actions/runs/13437160473/job/37542153912 I think https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/6052 broke it.

@thomas-topway-it does this change work for you? if it does I can merge it.

> which change ? I think if we can merge it would be great and we can fix later this #6052 This pull request? (https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/5690)

This is weird. phpcs passes for me locally (passes here as well but phpunit is failing with a OOM).

Looks like ScopeMemoryLimiterTest is the cause.