paladox

Results 222 comments of paladox

> @paladox regarding ScopeLimiter: here's a WIP PR #5882 I seemed to have fixed the issue by changing onlyMethods to addMethods and now I get other errors (not from this...

So https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/Search/SearchEngineFactory.php#L35 needs replacing since that returns a IDatabase rather than IConnectionProvider. Looks like we setup ConnectionManager in https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/Setup.php#L198 and so I'm not sure or rather I don't know how'd...

Nope, it's still not fixed yet. https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/Search/SearchEngineFactory.php#L38 needs to be fixed.

> @paladox can you verify? > > Seems like the `@depends` doesn't do what it supposed to do (keep the redirect and target page 'alive'). Tests are passing? But I'm...

https://github.com/highlightjs/highlight.js/pull/4230 will possibly fix this i think.