Oran Agra

i didn't mean they need to see the implementation, i meant we'll mention it in the free text of the doc (not as a field), and just for the ones...

> now it will always be wrapped in multi/exec @sundb sorry for circulating to this just now. are you saying that besides of whether or not this function is thread...

related to topic 4: i think the approach of using a protocol extension similar to the normal redis commands to multiplex different clients on the same TCP connection is limited,...

Seems like a good thing to add, but considering 7.0 is in late RC, i'd rather not rush it. let's add it for 7.2 Thanks.

we did that trick on purpose (it was my design) to avoid the extra memory consumption. in the current code we added just one more kvstore pointer per kvstore (by...

the worse case is not really a realistic one. and the extra 96 bytes for non-cluster mode isn't a real concern either. the bottom line is that we're considering wasting...

i see the code in 8.0 is ```c mstime_t expire = getExpire(key->db,key->key); if (expire == -1 || key->value == NULL) return REDISMODULE_NO_EXPIRE; ``` i.e. we would crash on NPD (similar...

> @oranagra > > > is the new code in this PR similar to the code in 8.0? > > The code before this PR is similar to 8.0. After...

I didn't review the code in detail, but i have 2 questions: 1. what's "direct dispatch architecture"? can you point me to the place in the code where that happens?...

this smells like a memory corruption to me. ``` #8 dictSdsKeyCompare (privdata=, key1=0x7f3bb34784b3, key2=0x0) at server.c:1260 ``` this means the key that was stored in the db dict is NULL....