Oran Agra

Results 511 comments of Oran Agra

or break keys to smaller pieces, which i understand isn't an option in your case.

thanks for bringing this up. > 1. Avoid rehash of db and expire at the same time > 2. ~Avoid multiple db rehash at the same time (standalone mode)~ >...

i don't think the number of clients (likely to be a lot of subscribers) is a good factor to use here. and i'd like to avoid a config (which will...

> @oranagra btw, out of the topic, do we have any idea to include rehash dict overhead in freeMemoryGetNotCountedMemory? In my fork, we included it assuming it is a temporary...

it's probably best if it's not boolean. i.e. we gradually allow more rehashing when the server is less busy.

i can't afford to review the code at the moment, commenting on the description. feel free to tag me on specific topics in the code though. Is this PR only...

please document a usage example of both module API and pubsub in the description. also, it looks like documentation in module.c, and in redis.conf is missing. i'm assuming the new...

LGTM. do we also generate a keyspace event, in addition to the key event? i.e. in one the channel is the event type and the data is the key name,...

LGTM (based on skimming over the interfaces and docs).

can you run `pstack` or `gdb -batch -ex "bt" -p ` a few times so we know which code path runs in a loop? anything you can tell us about...