onbjerg

Results 438 comments of onbjerg

Feel free to take a stab at it :) Let me know if you end up not being able to complete it and I will unassign you!

Hmm, thinking about it, you're right. Since we have the ABI we would know how to serialize/deserialize the return data

Please don't open issues unrelated to the book in the book repository

imo this is what `cast run` is for edit: nvm I see `cast run` just reruns a tx. Should be fairly simple to move the `cast run` logic into `cast...

Would note here that we can't lock into GPU only since some people use Cast on servers w/o GPUs

Should be added here: https://github.com/foundry-rs/foundry/blob/09a848cc7b7422ed4a2ec78ae1a72e7658ea22f7/evm/src/executor/inspector/cheatcodes/mod.rs#L230-L234 and the corresponding Solidity types. We would likely need to swap out `RawLog` for something else since the `RawLog` type does not include the emitter...

You'd add a test in `testdata/cheats` similar to the ones already there - there is already a file for `getRecordedLogs` so you'd just extend/change that. There isn't really a nice...

I also agree, should be in `cast receipt`

Do we need to do a `cast run`? I'd assume an `eth_call` is enough to get the revert reason, but maybe I'm wrong