onbjerg

Results 436 comments of onbjerg

No, I think I know how to handle those, I'm mostly unsure about the `new` keyword :smile:

Seems like the contracts just aren't identified. Are the traces decoded?

Ping @gigamesh is this still present?

@gakonst adding an example rn, but for example u could use it for `expectEmit` - its a long standing issue that the error msg sucks a lot here since it...

Not the best example (expectEmit will take more work) but instead of writing the really big number inside of the short test result it could be a hint: ![image](https://user-images.githubusercontent.com/8862627/189180046-b635e633-2a24-44fc-975d-cfa74617cf05.png) Similarly,...

Unclear how this should work with `forge test` since all of them run in parallel and we'd have to block the execution... Makes it super hard to test deploy scritps...

It's feasible-ish, but still some edge cases with `forge script` now that I think about it, e.g. when using the debugger it should also not work etc. Don't have a...

@mds1 Can we not achieve the same result by having the user confirm before broadcast instead? Possibly also using decoded transaction data?

@mds1 We already have all of the transactions before we broadcast them, so my idea was that we would display them all decoded so you can inspect them if you...