onbjerg

Results 436 comments of onbjerg

So it seems like it is because of the way the remappings are set up, but I'm still investigating exactly what happens. Essentially, each of your packages has a remapping...

Changing up the remappings a bit makes it sort of work, but the report is very cluttered because none of the sub-packages are *actually* dependencies, it just looks at it...

Can you post the tomls? Some parts of the toml are very important here since a misconfiguration leads to recursion in your repository

Yeah, that looks good! However I'm not sure if moving data fetching in to a hook would be better practice, since I'm just catching up with that concept. Would it...

That's great! Will it also support GitHub's auto-deploy feature like Heroku? It would be cool if Deis could create a staging or review app for pull requests 🥇

Not really, I put it off because I was planning a bigger rewrite but that is still on the backburner

We need to specify in here how this would even work given the current architecture, i.e.: - What assumptions do we make in the stages, tree, and RPC about data...

> Not persisting any changesets until the desired pruning height I'd recommend avoiding this if we want to support forward syncing in the future, since we can only really do...

Please ref https://github.com/paradigmxyz/reth/issues/2753 as well for additional ideas