Nok Lam Chan

Results 535 comments of Nok Lam Chan
trafficstars

I've moved this to `reivew` since the scope of the ticket is about define the scope. There are couple of people review this already, would like to get some opinion...

https://github.com/kedro-org/kedro/issues/4128#issue-2494292897 @merelcht I have opened a new ticket. My current idea is that the test should be easy to run both locally and also as Github action. We may use...

Not sure, was this failing with the earlier versions?

I think `SESSION_STORE_CLASS` is still needed. `SESSION_STORE_CLASS_ARGS` can be left as a comment for discoverability

Adding another option which operate at a lower level: https://libcst.readthedocs.io/en/latest/codemods_tutorial.html, or [pyupgrade](https://pypi.org/project/pyupgrade/)

> datasets that aren't in the catalog and don't match a pattern in the catalog and include MemoryDataset If a dataset is defined in catalog or as a pattern, the...

I get this in the second run it will be in the `registered_ds`. But the logic here is: free_output = output - register_ds (excluding if is a memory dataset) So...

For reference I shared my edge cases here: https://github.com/noklam/kedro-runner-bug-investigation/commits/main/

@datajoely I actually took a stab on this a while ago. My experience with it is Delta has a more mature support than Iceberg at the moment in the Python...