Nok Lam Chan comments

Results 536 comments of


                                            Nok Lam Chan

trafficstars

Spike: Make `cookiecutter` optional / not a core dependency of `kedro`

> Big fan of (2), pip install kedro including ["kedro-core", "cookiecutter", "rich"]. I will say this is (3). The most notable difference is that `pip install kedro` will automtically install...

Spike: Make `cookiecutter` optional / not a core dependency of `kedro`

> > Besides Nok's proposal, another idea to at least stop relying on Rich would be to try to handle the prompting outside of the cookiecutter context. That would allow...

Spike: Make `cookiecutter` optional / not a core dependency of `kedro`

See this from the fastapi community. Some arguments I see there: - libraries shouldn't try to include extra dependencies as default, but use optional dependencies when needed https://github.com/tiangolo/fastapi/discussions/11733

Validate hook_impl respect hook_spec

https://kedro-org.slack.com/archives/C03RKP2LW64/p1716480352120979 It's also valuable to validate the other way round which is common for user to forget to put `@hook_impl`

Allow returning modified dataset in `after_dataset_loaded` and `before_dataset_saved` hook

It looks like @mjspier is already using `kedro-pandera`. I do not think modifying data in hooks is a good idea in general: - hooks execution order are not strongly guaranteed...

Snowflake Alter Table ... Alter Column ... DROP NOT NULL doesn't parse correctly

I would love to take on this issue if possible. I try to modify the query to ``` query = """ ALTER TABLE DB_NAME.SCHMA_NAME.TBL_NAME ALTER COLUMN MY_COLUMN DROP DEFAULT; """...

Snowflake Alter Table ... Alter Column ... DROP NOT NULL doesn't parse correctly

https://github.com/tobymao/sqlglot/blob/59de4f6e0f48f5354e7b462fb65633018184aa3c/sqlglot/parser.py#L6024-L6038 This is as far as I can trace so far, so it seems like this is a Parser problem. Since this is a Snowflake specific syntax, this should probably...