Nok Lam Chan

Results 539 comments of Nok Lam Chan
trafficstars

![image](https://github.com/kedro-org/kedro/assets/18221871/650905d9-e8c9-48eb-bad7-3e3fe9dee3ae)

A more updated fork seems to suggest this is a bug. https://github.com/chy111126/debug_kedro_0182 The problem is the use of `env` and CLI `--params` is interacting weirdly. 1. kedro run --env=add --params="aaa.bbb.abb=2023-11-11"...

Further testing, I try to switch to `ConfigLoader` with 0.18.14 and the issue is gone. I did another test to upgrade to 0.19.1 with OmegaConfig and the issue is back.

A temporary workaround is to use `settings.py`, note this shouldn't be needed because the top-level key has no conflict. We should still investigate the issue. ``` CONFIG_LOADER_ARGS = { "merge_strategy":...

``` config={'aaa': {'bbb': {'aba': '2023-11-01', 'abb': '2023-11-11', 'abc': 14}}, 'xyz': {'asdf': 123123}} env_config={'def': {'gg': 123}, 'aaa': {'bbb': {'abb': '2023-11-11'}}} resulting_config={'aaa': {'bbb': {'abb': '2023-11-11'}}, 'xyz': {'asdf': 123123}, 'def': {'gg': 123}} ```...

In a discussion today, we found out that https://github.com/kedro-org/kedro/pull/3290 changes the simple dict merge to a OmegaConf.merge, and is likely the root cause of a few bugs. @SajidAlamQB Do you...

@SajidAlamQB make sense, it's still unclear whether OmegaConf.merge affect this issue, it is more clear that it causes https://github.com/kedro-org/kedro/issues/3620. Omegaconf expect raw config, but the config would have resolved at...

> The conflict is caused by: > kedro 0.19.6 depends on gitpython>=3.1.32 > kedro[test] 0.19.6 depends on gitpython>=3.1.32 > trufflehog 2.2.1 depends on GitPython==3.0.6 > kedro 0.19.6 depends on gitpython>=3.1.32...

Sorry for the late response, @sagrawal128 How big is the project? Is the setup very heavy that it takes a lot of time? During `%reload_kedro`, Kedro basically try to create...

As stated, we need to ensure a date_prefix so the order is maintained, adding a suffix should be fine. I am pro for this as I have need for this...