Nicky Gerritsen

Results 146 comments of Nicky Gerritsen
trafficstars

The message is missing *why* we need this. If you can add that, we will merge.

We use data tables now. The problem is that we also want pagination in some places and that is not compatible

I removed it from the merge queue for now. We need to think about it maybe more, but currently we can't import these submissions and thus have differences. Maybe we...

In fact I like that: if one of the things from the shadow don't follow our settings, mark it as import error and don't create a judging. Wdyt?

Tested this code at NAC dress and it seems to work: ![image](https://github.com/user-attachments/assets/c1d5d445-984d-47d5-8425-25eb11a6af80)

@johnbrvc does it hurt for you, more than that you run a codepath to check if the judgement changed? I wonder if this is a CLICS discussion as well, can...

> IIRC, we did this intentionally to make the event feed and endpoints match. > > Cc @eldering Yeah this is what I'm thinking as well, hence my last sentence.

Note that we also update the max run time to be the max of all runs. This then also needs to change to only take the max of runs that...

Seems to be the same as https://issues.shopware.com/issues/NEXT-8354.