domjudge icon indicating copy to clipboard operation
domjudge copied to clipboard

When we shadow, trust the filenames and file sizes.

Open nickygerritsen opened this issue 6 months ago • 6 comments

nickygerritsen avatar May 25 '25 19:05 nickygerritsen

Hmmm after seeing the issue you filed I'm no longer sure I approve... Have to think more

meisterT avatar May 25 '25 19:05 meisterT

I removed it from the merge queue for now. We need to think about it maybe more, but currently we can't import these submissions and thus have differences.

Maybe we should import them as import-error, which should make them not judge in DOMjudge.

nickygerritsen avatar May 25 '25 19:05 nickygerritsen

In fact I like that: if one of the things from the shadow don't follow our settings, mark it as import error and don't create a judging. Wdyt?

nickygerritsen avatar May 25 '25 19:05 nickygerritsen

That sounds indeed better and doesn't require us to change internal assumptions

meisterT avatar May 25 '25 19:05 meisterT

Let me change this PR then

nickygerritsen avatar May 25 '25 20:05 nickygerritsen

Tested this code at NAC dress and it seems to work: image

nickygerritsen avatar May 25 '25 20:05 nickygerritsen