Nabil Freij

Results 808 comments of Nabil Freij

> > What about for the other clients that don't use the scraper? > > Sorry for the long break @nabobalis . I think , for those clients that dont...

I guess what I am trying to get at is that I think you need to take a step back and work out how errors propagate through the clients currently....

> Let me start from the basics . There are a number of clients right now ... > > 1. The generic client based clients use the same search method...

> > But what errors need propagating from the scraper and how will that be done? > > after `x` number of retries , if we still get an error...

> > Is that the only error? > > the http_err object is the standard interface , which can throw all the other http errors . So yes , I...

> > And this covers what http errors? > > currently just 404 and 429 Ok, are those all the one we need to worry about? Those are raised by...

> Nope , I think the scraper can be more robust , like handling different types of errors like 504 , and 404 (which is currently being ignored) and handling...

As things stand, I don't think this PR will be merged in. For now the original issue was with the scraper, so we should seperate them in any follow up...

We did not talk about this at the AGU, shall we talk about this at the next weekly meeting?

> @nabobalis looks like there is some interest in this functionality belong in SunPy, correct? Correct.