Nabil Freij

Results 805 comments of Nabil Freij

> Hence the TODO that I wrote: `# TODO: Find somewhere more appropriate to define these constants` > > The constants are not defined in astropy nor does it make...

Sounds good to me, let's do it. Could it be sunpy.constants.moon and sunpy.constants.sun?

In that case, the dict that Albert posted should be the method we use instead of a class.

There is already a PR open here: https://github.com/sunpy/sunpy/pull/7489 if you could help that would be ideal than another PR.

Can you add code suggestions to the original PR that I linked to?

> Hello @DanRyanIrish sir , if this issue is still open , so can i work on it ? You are free to work on this issue. > > While...