Nabil Freij

Results 805 comments of Nabil Freij

Only failing test is: FAILED ../../.tox/py312-online/lib/python3.12/site-packages/sunpy/net/vso/vso.py::sunpy.net.vso.vso.VSOClient.search

I don't know if it's possible yet. You want it in this PR?

Online fail is: FAILED ../../.tox/py312-online/lib/python3.12/site-packages/sunpy/io/tests/test_filetools.py::test_write_file_fits[aia_171_image.fits] - FileNotFoundError: [Errno 2] No such file or directory: 'aia_171_image.fits'

Thank you for the detailed report. Can you try the web UI for the VSO and see if those return the files? If that does, then we know its a...

> @nabobalis , have drafted a tentative pr showing what changes i mean to do . The responses are too plain and generic , we can refine this , while...

How does this look to a user? Do you have examples of a user query and the return/output when you hit this code?

I think it has to work with a unifiedresponse. I would still first replicate a server error and then work out how what happens to a query.

> > I think it has to work with a unifiedresponse. > > Then we can add a warning attribute to it and return it as a warning string ?!....

I personally don't see the need for a warning if the server was fine but there are no results

What about for the other clients that don't use the scraper?