Max Held

Results 208 comments of Max Held

this might actually work if we test inside the entrypoint whether 1st argument is given, and then to default to $JUST_GH_REPONAME

we figured out another (better) way via non-simple graphs. I'm going to leave this open in case anyone else finds this interesting.

I *think* this is exactly the feature I've been looking for (have also recently discussed this on the mailing list). To confirm / flesh this out: This would let users...

> What would be the alternative to mocking in practice for an API package? If I understand these "critiques" (if that's what they are?) correctly, I think the alternative to...

> To what extent do those two blog posts include mocking http requests specifically vs. test mocks in general? Does it matter? They mostly cover mocks in general, and mostly...

btw, I love that you guys are hard-wrapping by sentence in the rmd ☺️. Been trying to lobby the tidyverse to adopt that elsewhere: https://github.com/tidyverse/style/issues/162

Great + agreed! I'll work in those suggestions @maelle -- could be a day or two.

yikes, sorry I took so long to follow up: > I like the content but feel it should come later in the book are things are complicated enough at this...

thanks so much for taking the time to so carefully review this again @maelle! I've fixed some of the smaller things and changed the chapter location. But I'm not sure...