Max Held

Results 208 comments of Max Held

on closer inspection, it turns out that the ubuntu-vms on the new yaml-based GitHub Actions already ship with `rsync`, so there really is no need for a separate, container-based action....

mmh but then again, it is a pretty long script that *should* be factored out somewhere. Also, if people use `container:` for the entire job, then they can't use the...

I think I got it now; to factor out the code, this needs to be a node.js action.

in particular, #1

thanks for raising this, I hadn't thought about that. I hacked this together on a shoestring, and so I'm generally worried that the ssh usage isn't up to par here....

on closer inspection of the `entrypoint.sh` and the github actions docs, I'm not 100% sure that this isn't actually a github bug / undocumented behavior, as per below message to...

question: > sorry, that was a bad commit indeed. > > Here's the correct one: https://github.com/maxheld83/ghaction-rsync/tree/54878e91d6823cb53244eccc69475e245a6471f7 > > Steps to reproduce: > Create some environment variable in the entrypoint.sh (here,...

so the bottom line seems to be that when pasted into arg, this stuff automatically gets escaped, and these escapes prevent that $JUST_GH_REPONAME gets evaluated.

can't think of an elegant way to implement this without greatly complicating the design, so this is going to remain blocked.