Maximilian Roos

Results 1148 comments of Maximilian Roos
trafficstars

What would the options be for moving this forward? - Try / Except import blocks, like we do for other libraries - A separate package (could be in the same...

FYI I think https://github.com/pydata/xarray/pull/8460 should solve most of this. Or would anything remain? > `zeros_like()` allocates memory, doesn't it? Same with `empty_like`. If you are in the business of incrementally...

FWIW this seems to be correct under numbagg or bottleneck; so it's an issue with the naive xarray routines. We could just raise an error there. ``` Expected: Size: 48B...

I'd be fine with disabling, since bottleneck doesn't seem to be actively maintained. Though I would say it's numerically unstable rather than incorrect! I would always want it enabled, but...

As an update — numbagg is in a pretty good place now, and xarray defaults to using numbagg over bottleneck for overlapping functions when both are installed. (I didn't finish...

Nice!! --- (One small difference between that and the PR — we possibly should write any var that doesn't have a region dim, not only the indexes)

To the extent that it's helpful and not annoying to add "this would be really useful": this would be really useful! It seems fairly close IIUC (though easy for me...

> I'm fine with getting this out into the wild, but I am hesitant to commit to it as permanent API. Could we say it is an experimental feature, don't...

> It's also always unsafe for parallel writes with `region="auto"` because we have workers reading from these same indexes as they're being overwritten. Yes this! --- I both agree that...

Actually I think https://github.com/pydata/xarray/pull/8460 might dominate this — by returning the dataset to write, it's moving the proposed magic out of `.to_zarr` into a single place where the inputs &...