Maximilian Roos

My question is — what if the comment is in the middle of these? For example: ```rust r += opt.consume(" ")?; // writes " " r += opt.consume(&op.to_string())?; // writes...

~Yes, good idea — that could work — though at the cost of not honoring the original placement of comments or line-wraps. So:~ ```elm from foo derive bar = x...

> I don't think you understood me: approach I've described would not move comments "trough" expressions. In your example it would keep the comment before `y`. > > It would...

I think this mostly "works", but is extremely bad code, some of the worst I've written :). I simplified the before / after comment functions, but this means that I...

> I assume you wanted to have global place for the `tokens` vec so it is not cloned all the time. I suggest you use `Rc` instead. It is cheap...

OK so I did some light research and one approach seems close to our current one, and will avoid the current issues in the PR: Iterate over the tokens, and...

To keep this updated: in #4639 I tried a version of this (though slightly different implementation — instead it adds them at parse time): > OK so I did some...

Yes agree. What's the class of functions that require the `ORDER BY`? There's `WINDOW`, though possibly that's a separate issue entirely. How would we encode this? We have a field...

Why? I put a framework for discussion here: https://github.com/PRQL/prql/pull/3791#issuecomment-1854678506 Having them in another repo is arguably _harder_ to maintain... Are they much effort to maintain at the moment?

Definitely worth checking out some of the `git cliff` outputs and seeing what we thinks looks best. I am keen to reduce the burden of releasing as much as possible,...