Maximilian Roos comments

Results 1161 comments of


                                            Maximilian Roos

trafficstars

`"source"` encoding for datasets opened from `fsspec` objects

Without knowing much (I generally `ds.reset_encoding()`) it does sound like a good idea!

combine_first() fails when DataArrays are read from netcdf

This does seem off. And notably it works on 2024.2.0

Xarray sponsorship guidelines

LGTM!

mypy does not understand output of binary operations

I coincidentally came across this today — I think it might be the same issue, but can open a new issue if not. With this code: ```diff diff --git a/xarray/tests/test_variable.py...

mypy does not understand output of binary operations

Yes, you're completely correct — thanks! I'll minimize these to reduce the noise

mypy does not understand output of binary operations

Is there anything we can do here or should we close?

```DataArray.sel``` can silently pick up the nearest point, even if it is far away and the query is out of bounds

To confirm, this is limited to the case when `method="nearest"` is passed; is that correct? How about adding a `method="interp"` to `.sel`? Then that's clearly discriminated from `method="nearest"`, which would...

```DataArray.sel``` can silently pick up the nearest point, even if it is far away and the query is out of bounds

Yes, sorry, my message was unclear. It could be named `method="nearest-surrounded"` (or some better name). My point was that we could offer an option to explicitly select internal points, rather...

```DataArray.sel``` can silently pick up the nearest point, even if it is far away and the query is out of bounds

I hadn't thought of this behavior as likely a bug. I also don't use this myself that much, so interested in what others think / whether you're confident here.

```DataArray.sel``` can silently pick up the nearest point, even if it is far away and the query is out of bounds

> For example looking up lat=-120 while lat range was 0...360 and not -180...180 in our case. Yes, it makes sense that this is not intended. But can we write...