Maximilian Roos

Results 1223 comments of Maximilian Roos

Yes agree, this should be an error

We should be locked at 1.65 based on https://github.com/PRQL/prql/blob/main/rust-toolchain.toml — how are you seeing errors for 1.66 (possibly with `override`?) Happy to take a PR to adjust this now, and...

I think possibly this only works for maintainers? I see: Happy to have a footnote to on that link to say this...

> pre-commit.ci autofix I don't get why this was required — this should be the default. Possibly because it was failing on a commit from itself, and pre-commit doesn't know...

Excellent! I'll take a pass later. Would you prefer this is from "the project" or from you? I notice it doesn't have your name at the moment. I would think...

> Expect it to fail on Windows but provides a test case FYI this now passes because of https://github.com/PRQL/prql/pull/1456/files#diff-b73931d39044edca7c78f83713af7326a8d63dac151088b8d905e39f060ed8a6R69-R72, when removed it'll fail again

> > Expect it to fail on Windows but provides a test case > > FYI this now passes because of https://github.com/PRQL/prql/pull/1456/files#diff-b73931d39044edca7c78f83713af7326a8d63dac151088b8d905e39f060ed8a6R69-R72, when removed it'll fail again Now upgraded to...

I think waiting to resolve https://github.com/mitsuhiko/insta/issues/351 may make sense; otherwise folks may be getting large confusing diffs locally

*Edit: this is now fixed* --- Here's a panic, which should error because of the function call without parentheses: ```elm from employees derive foo = round 1+1 bar ```

@aljazerzen could this be a Good First Issue? I'm thinking that given an example, folks can find the panic fairly easily, and change it from `.unwrap` to an `Error`?