prql icon indicating copy to clipboard operation
prql copied to clipboard

the feature `backtrace` has been stable since 1.65.0 and no longer requires an attribute to enable

Open yurivict opened this issue 2 years ago • 1 comments

[eyre 0.6.8] error[E0407]: method `backtrace` is not a member of trait `Error`
[eyre 0.6.8]   --> /usr/ports/lang/prql-compiler/work/target/x86_64-unknown-freebsd/release/build/eyre-ccbaaab4d138bf20/out/probe.rs:19:9
[eyre 0.6.8]    |
[eyre 0.6.8] 19 | /         fn backtrace(&self) -> Option<&Backtrace> {
[eyre 0.6.8] 20 | |             let backtrace = Backtrace::capture();
[eyre 0.6.8] 21 | |             match backtrace.status() {
[eyre 0.6.8] 22 | |                 BacktraceStatus::Captured | BacktraceStatus::Disabled | _ => {}
[eyre 0.6.8] 23 | |             }
[eyre 0.6.8] 24 | |             unimplemented!()
[eyre 0.6.8] 25 | |         }
[eyre 0.6.8]    | |_________^ not a member of trait `Error`
[eyre 0.6.8] 
[eyre 0.6.8] error[E0554]: `#![feature]` may not be used on the stable release channel
[eyre 0.6.8]  --> /usr/ports/lang/prql-compiler/work/target/x86_64-unknown-freebsd/release/build/eyre-ccbaaab4d138bf20/out/probe.rs:2:16
[eyre 0.6.8]   |
[eyre 0.6.8] 2 |     #![feature(backtrace)]
[eyre 0.6.8]   |                ^^^^^^^^^
[eyre 0.6.8] 
[eyre 0.6.8] warning: the feature `backtrace` has been stable since 1.65.0 and no longer requires an attribute to enable
[eyre 0.6.8]  --> /usr/ports/lang/prql-compiler/work/target/x86_64-unknown-freebsd/release/build/eyre-ccbaaab4d138bf20/out/probe.rs:2:16
[eyre 0.6.8]   |
[eyre 0.6.8] 2 |     #![feature(backtrace)]
[eyre 0.6.8]   |                ^^^^^^^^^
[eyre 0.6.8]   |
[eyre 0.6.8]   = note: `#[warn(stable_features)]` on by default
[eyre 0.6.8] 
[eyre 0.6.8] error: aborting due to 2 previous errors; 1 warning emitted

rust-1.66.0

yurivict avatar Jan 03 '23 08:01 yurivict

We should be locked at 1.65 based on https://github.com/PRQL/prql/blob/main/rust-toolchain.toml — how are you seeing errors for 1.66 (possibly with override?)

Happy to take a PR to adjust this now, and we'll need to update it when we move to 1.66 (We run on n-1, so we'll upgrade to 1.66 when 1.67 comes out)

max-sixty avatar Jan 03 '23 16:01 max-sixty