Maximilian Roos

Results 1204 comments of Maximilian Roos

What is `d` is that example? Can we make an MCVE with vs without xarray?

> #### > > Example of flaky tests from my recent experience, on the same PR, failing on two different runs: > > * `FAILED xarray/tests/test_backends.py::TestDask::test_dask_roundtrip` only for stage [windows-latest...

Could this be https://github.com/pydata/xarray/issues/8371 ?

What happens if we filter out values with `.where` prior to stacking — does it still create huge arrays? (An MCVE would help here...)

Great idea! Really cool. I even wonder to what extent this could replace vast swathes of our tests — anything where the output is calculated from the input. We'll always...

Thanks for the excellent issue @brendan-m-murphy . This is really surprising. If we look at these two objects, there's no `y` to be found: ```python [ins] In [3]: ds1_swap Out[3]:...

> It might be worth looking at the `._indexes` property of the datasets obtained after `rename_vars` and/or `swap_dims`. Thanks for the response + the idea. It's indeed on the `dim`:...

Thanks for the PR. I don't have a strong view but one quick question — could you instead implement the methods that get checked on the custom object?

Ah I see, thanks. --- I wonder if we could alternatively check that doesn't have `Hashable` implemented. So if you implemented `Hashable`, then xarray would not see it as dict-like....

> Can we just skip the check if the dimension being indexed is backed by an `object` dtype array? This seems worth trying. I'm not sure exactly how multiindexes will...