Maximilian Roos

Is there a case where someone is writing a library that consumes xarray, type-checks their library, and their type check then fails? If so, I think we should prioritize fixing...

> Additionally, `xarray` is a small-ish repository, and running `black` on the entire code base (which is a rare thing to do outside of CI) completes in less than a...

I notice that the diff is now quite large? I guess that's the `preview` flag? And that mypy is failing? If we can reduce the size of the diff as...

> I'll try to keep this draft PR updated as a "showcase" of what applying ruff alongside a `pre-commit run --all` would look like OK perfect!

Good to have this in the docs given we haven't fixed the issue. But I think we should phrase this as a bug and link to the issue, since it's...

Closing as upstream; please reopen with an MCVE if that's not correct

If you want to read up on this, look for "view vs copy"!

> (relatedly, would it be worth it to link to the relevant numpy [docs](https://numpy.org/doc/stable/user/basics.copies.html) in [this](https://docs.xarray.dev/en/v2024.01.1/user-guide/indexing.html#copies-vs-views) part of the xarray docs?) Yes! That would be a welcome contribution. --- >...

That is pretty curious @saschahofmann . I'm trying to repro. I also get a process that doesn't finish, but a) I get lots of errors, b), I also get it...

Thanks for investigating. If you can generate a repro with xarray, which works without xarray, that would be great...