Matt Wang

Results 380 comments of Matt Wang

> i'd love to help work on this slide on in :) > were y'all also considering making a design doc a requirement for every issue/PR perhaps? Hm, that's up...

Hi @jonschlinkert, just opened a PR at #47 to take a stab at this - let me know what you think!

The history surrounding this is actually a bit suspect - going to not merge this in for now. We're not affected by this vulnerability anyways.

> it might be better to prefix all IDs generated by the theme with jtd-, to minimise the risk of clashes. Hm, I would prefer to avoid doing that since...

Also, as a heads up --- once the validator passes, HTML Proofer seems to fail (since there will now be links to headings that no longer exist, etc.). Let me...

> Could HTML Proofer be persuaded not to fail for such links? This issue isn't specific to this PR. Hm, that's a good question! Ideally in this case, we should...

Perfect - thanks for handling this merge (and for contributing this feature) --- excited to release it soon! (some other PRs that I'll be looking at soon: #1514, #1461, #1232...

> So releasing soon is probably best. SGTM! I'll try to work on that soon. > BTW, the updated docs have many callouts stating "NEW (MULTI-LEVEL)". Perhaps they should be...

> BTW, the updated docs have many callouts stating "NEW (MULTI-LEVEL)". Perhaps they should be changed to "NEW (v0.10)" after releasing the feature? Done in 3e6e3ab!