Matt Wang
Matt Wang
Closing in favour of #48.
Just with a month left in the summer - want to give a chance for @doubleiis02 to chime in first! I do have some thoughts but I'll save them for...
> Thanks for this @lamasfoker. @mattxwang I saw your reply a while back but have just been too smashed at work to get around to it. Thanks for merging it...
@nicolasjeong is this PR ready to review? I'm not sure if we've hit all the requested items in the ticket yet!
> Oh my bad, I thought I had to submit a PR after resolving some of the comments from checkImageSize.js before moving on to fixImageSize.js. (Unless I missed something in...
Oh I can jump in here if that makes things easier, basically the entire file is being executed on interpretation (afaik how importing works with ESM/node, but I could be...
> @mattxwang Oh ok, so if I'm understanding this correctly, if we had functions that we wanted to use in both checkImageSize.js and fixImageSize.js then we should define the function...
Just touching back to this, @reginawang99 / @vivianha534 are y'all wrapping up this ticket? Or do you want me to finish it?
Just curious, what ended up happening with this PR? @vivianha534 @reginawang3495
My two cents as a retiree - might be better to make this two separate pages, i.e. * setting up your environment for the website * setting up your environment...