Mattijn van Hoek

Results 279 comments of Mattijn van Hoek
trafficstars

Rebased to retrigger the Github Actions. All pass now, so merging. Thanks again @xujiboy!

Thanks @binste! Which category is this supposed to be? It's currently in `other charts` but that category is not there anymore.

thanks again @yanghung, and the floor is yours @binste;)

I noticed that the changes to the tests are aiming vegalite/v4, you probably want to change this to vegalite/v5 if you think this PR should be merged @joelostblom.

I looked to the code changes and looked to the related issues PRs, but I still feel I miss a bit of context. Would it be possible to include a...

I agree. Since the introduced behaviour is only targeting pandas data frames with ordered categorical columns the unintended consequences are, as far I can see, limited. But the introduced behaviour...

Hi @joelostblom can you synchronise your branch, https://github.com/joelostblom/altair/tree/schema-validation-error, with the main repo and maybe add a code-snippet how to this can be tested easily using eg. colab. This will help...

I think it is a really nice PR. Thanks @joelostblom. Really helpful, nice that it gives suggestions. It makes me want to make mistakes on purpose to read the suggestions.....

Just to check @binste, I could not find the documentation in the encoding channel options on x/yOffset in https://binste.github.io/altair-docs/user_guide/encodings/channel_options.html. I think it be as included as follow: ```cmd XOffset and...

Once https://github.com/jupyterlab/jupyterlab/pull/13893 is merged, this issue can be closed