altair icon indicating copy to clipboard operation
altair copied to clipboard

Add waterfall chart example

Open yanghung opened this issue 3 years ago • 1 comments

yanghung avatar Jun 21 '22 19:06 yanghung

@yanghung When you are addressing the comments I made, could you also rebase this on the latest main branch so that the CI tests above pass (I recently committed a fix)?

joelostblom avatar Jul 03 '22 13:07 joelostblom

If you merge the PR in its current state I can create a follow-up one in the next few days to address the open points. If it doesn't work due to the failed checks I can also copy over the code from here and add @yanghung as an author.

binste avatar Dec 17 '22 07:12 binste

Thanks @binste! Which category is this supposed to be? It's currently in other charts but that category is not there anymore.

mattijn avatar Dec 17 '22 08:12 mattijn

As it contains quite a few transformations I'd suggest to place it into Advanced Calculations # category: advanced calculations.

binste avatar Dec 17 '22 08:12 binste

thanks again @yanghung, and the floor is yours @binste;)

mattijn avatar Dec 17 '22 09:12 mattijn