Mattijn van Hoek

Results 277 comments of Mattijn van Hoek
trafficstars

Yes there is still a common pattern affected. The second comment is still problematic. It was raised as well in https://github.com/altair-viz/altair/issues/2713. I'm somehow surprised your code fix this issue @ChristopherDavisUCI....

You remove the `name` from the encoding? In my understanding there is no `name` key within `encoding`. I think what you do is you import the `name` and define it...

Yes it does! Thanks for explaining. I notice there is also an `lineOverlay` next to `pointOverlay`. I don't think we had that combination tested yet on the Altair side. So...

Fixed by https://github.com/vega/vega-lite/pull/8662

You are right! This is fixed along the way. Great. If you want to hide the `alt.selection` from the autocomplete, you'll have to assign `alt.selection` a deprecated status around here...

Hm, not sure. This is the current docstring for `alt.param`, https://github.com/altair-viz/altair/blob/master/altair/vegalite/v5/api.py#L303-L320. ```python def param(name=None, select=None, **kwds): """Create a named parameter. Parameters ---------- name : string (optional) The name of the...

In the context of Altair, `None`, serializes to `null` in JavaScript, sometimes that is desired. Again, in the context of Altair, you probably want `Undefined` most of the time.

Thanks for this PR @rahul-raoniar, but I agree with @joelostblom. Let me close this PR.