Matthew McGarvey

Results 134 comments of Matthew McGarvey
trafficstars

Getting a feel for the context of the issue: - [csrf token set on form](https://github.com/luckyframework/lucky/blob/078b432d646b66acb3dca7efa659524b9fa32f65/src/lucky/tags/form_helpers.cr#L8) - [value from token pulled from ProtectFromForgery class](https://github.com/luckyframework/lucky/blob/078b432d646b66acb3dca7efa659524b9fa32f65/src/lucky/tags/forgery_protection_helpers.cr#L11) - [the value is pulled from the...

Rails' implementation: https://github.com/rails/rails/blob/master/railties/lib/rails/secrets.rb https://github.com/rails/rails/blob/master/activesupport/lib/active_support/message_encryptor.rb

A nice first step to this would be to extract out the HTML DSL into a new module and separate the Lucky-specific tags/helper methods

See https://github.com/luckyframework/lucky/discussions/1655 for why this is useful to reconsider

Seems that the standard compiler error has changed now with Crystal v1.5.0. Thinking about what would be expected and using my picture as an example... ideally it should point to...

So the problem goes away if I move the methods into the component or I inline the `mount` code. There is a bug on crystal for this error message, could...

Verified to still be an issue on Crystal v0.36.1

Verified to still be an issue on Crystal v1.3.0 (and v1.3.2 just to be sure) 😢

I didn't realize that the intention of the was to include it in Avram models. With the annotation dictating what to ignore, is it possible to include it in a...